Return correct status and data when client sends bad requests

main.go

@@ -22,6 +22,7 @@ func setupRouter(env *Env, spotifyID string, spotifySecret string) *gin.Engine {
 	r.Use(spotifyAuth(spotifyID, spotifySecret))
     r.GET("/alive", env.alive)
     r.GET("/artists/:artistID", env.getArtistByID)
+    r.GET("/artists", env.getArtistByName)
     return r
 }
 

routes.go

@@ -5,6 +5,7 @@ import (
 	"gorm.io/gorm/clause"
     "net/http"
     "log/slog"
+	"fmt"
 )
 
 func (env *Env) alive(c *gin.Context) {
@@ -22,6 +23,15 @@ func (env *Env) getArtistByID(c *gin.Context) {
 
 	spotifyResponse, err := getSpotifyArtistData(artistID, spotifyAuthToken)
 	if err != nil {
+		statusCode := err.(*ResponseError).StatusCode
+		switch statusCode {
+			case 404:
+				c.JSON(http.StatusNotFound, gin.H{"Error": "This artist does not exist"})
+				return
+			case 400:
+				c.JSON(http.StatusBadRequest, gin.H{"Error": "Bad request"})
+				return
+		}
 		slog.Error("[GOMUSIC] Failed to request latest spotify data from API", "Error", err)
 		c.JSON(http.StatusInternalServerError, gin.H{"Error": "Failed to request the latest data from spotify API"})
 		return
@@ -55,3 +65,21 @@ func (env *Env) getArtistByID(c *gin.Context) {
     // Send back our response data
     c.JSON(http.StatusOK, spotifyResponse)
 }
+
+func (env *Env) getArtistByName(c *gin.Context) {
+	artistName, exists := c.GetQuery("name")
+	if !exists {
+		c.JSON(http.StatusBadRequest, gin.H{"Error": "name parameter was not supplied"})
+		return
+	}
+
+	// Lookup this name in the DB and return any ArtistProfile objects
+	var artistProfiles []ArtistProfile
+	dbResult := env.db.Where("name LIKE ?", fmt.Sprintf("%%%s%%", artistName)).Find(&artistProfiles)
+	if dbResult.Error != nil {
+		slog.Error("[GOMUSIC] Failed to query local database for artist name", "Name", artistName)
+		c.JSON(http.StatusInternalServerError, gin.H{"Error": "Failed to lookup name"})
+		return
+	}
+	c.JSON(http.StatusOK, artistProfiles)
+}

utils.go

@@ -2,6 +2,7 @@ package main
 
 import (
 	"fmt"
+	"errors"
 	"net/http"
 	"encoding/json"
 )
@@ -13,6 +14,15 @@ type SpotifyResponse struct {
        Genres []string
 }
 
+type ResponseError struct {
+	StatusCode int
+	Err error
+}
+
+func (r ResponseError) Error() string {
+	return fmt.Sprintf("Response error with status code: %d, error: %v", r.StatusCode, r.Err)
+}
+
 // Makes a request to spotify API to grab artist data
 // And parse the results into a properly typed struct
 func getSpotifyArtistData(artistID string, spotifyAuthToken string) (SpotifyResponse, error) {
@@ -20,22 +30,38 @@ func getSpotifyArtistData(artistID string, spotifyAuthToken string) (SpotifyResp
 	artistEndpoint := fmt.Sprintf("https://api.spotify.com/v1/artists/%s", artistID)
     req, err := http.NewRequest("GET", artistEndpoint, nil)
     if err != nil {
-		return SpotifyResponse{}, fmt.Errorf("Failed to build HTTP request to spotify: %w", err)
+		respErr := &ResponseError{
+			StatusCode: 500,
+			Err: errors.New("Failed to build request"),
+		}
+		return SpotifyResponse{}, respErr
     }
     req.Header.Add("Authorization", spotifyAuthToken)
 
     // Send off request
     resp, err := http.DefaultClient.Do(req)
     if err != nil {
-		return SpotifyResponse{}, fmt.Errorf("Failed to get artist data from spotify API: %w", err)
+		respErr := &ResponseError{
+			StatusCode: 500,
+			Err: errors.New("Failed to send request to spotify"),
+		}
+		return SpotifyResponse{}, respErr
 	} else if resp.StatusCode != 200 {
-		return SpotifyResponse{}, fmt.Errorf("Failed to get artist data from spotify API due to response status: %s", resp.Status)
+		respErr := &ResponseError{
+			StatusCode: resp.StatusCode,
+			Err: errors.New("Failed to get artist data from spotify API"),
+		}
+		return SpotifyResponse{}, respErr
     }
 	
 	var spotifyResponse SpotifyResponse
 	err = json.NewDecoder(resp.Body).Decode(&spotifyResponse)
     if err != nil {
-        return SpotifyResponse{}, fmt.Errorf("Failed to read response body data from spotify: %w", err)
+		respErr := &ResponseError{
+			StatusCode: 500,
+			Err: errors.New("Failed to decode response body"),
+		}
+        return SpotifyResponse{}, respErr
     }
     
     // Close this immediately since it's unused now