routes.go

@@ -72,9 +72,7 @@ func (env *Env) getArtistByName(c *gin.Context) {
 	}
 
 	// Lookup this name in the DB and return any ArtistProfile objects
-	// NOTE: This is case insensitive on sqlite
-	// NOTE: However unicode is treated case sensitive due to very difficult conversions for some languages/characters
-	// NOTE: In future better DBs with unicode support such as postgres should be used
+	// This is case insensitive on sqlite
 	var artistProfiles []ArtistProfile
 	dbResult := env.db.Where("name LIKE ?", fmt.Sprintf("%%%s%%", artistName)).Preload("Genres").Find(&artistProfiles)
 	if dbResult.Error != nil {

routes_test.go

@@ -36,13 +36,13 @@ func TestGetArtistByIDRoute(t *testing.T) {
 	// Dynamic data is hard to test so here we validate JSON response
 	// And we check known fields which are not likely to change
 	// We then check that the DB was updated correctly just to be sure
-	var resp ArtistProfile
-	err := json.NewDecoder(w.Body).Decode(&resp)
+	var spotifyResp SpotifyResponse
+	err := json.NewDecoder(w.Body).Decode(&spotifyResp)
 	if err != nil {
 		assert.Fail(t, fmt.Sprintf("Could not validate and parse JSON response into SpotifyResponse struct: %s", err.Error()))
 	}
-	assert.Equal(t, "0TnOYISbd1XYRBk9myaseg", resp.SpotifyID)
-	assert.Equal(t, "Pitbull", resp.Name)
+	assert.Equal(t, "0TnOYISbd1XYRBk9myaseg", spotifyResp.ID)
+	assert.Equal(t, "Pitbull", spotifyResp.Name)
 
 	var artist ArtistProfile
 	dbResult := env.db.Take(&artist)